bool CUSBLProcess::ReplyTransponderState(QByteArray byUSBLData)
{
    bool bParseOK = false;
    QString strUnpacketData = "";
    if(m_DataProtocol.UnpacketData(std::move(byUSBLData), strUnpacketData))
    {
        QDomDocument doc;
        doc.setContent(strUnpacketData);
        if(!doc.isNull())
        {
            QDomElement elementObject = doc.documentElement();
            if(!isValidReply(elementObject))
            {
                return false;
            }
            QDomNode node;
            QDomNamedNodeMap AttributeNodeMap;
            QDomNodeList nodeList = elementObject.elementsByTagName("SynchStatus");
            if (!nodeList.isEmpty() && !(nodeList = nodeList.at(0).toElement().elementsByTagName("Job")).isEmpty())
            {
                node = nodeList.at(0);
                if(!node.isNull() && !node.attributes().namedItem("RemoteControlEnabled").isNull() && !(nodeList = node.toElement().elementsByTagName("Objects")).isEmpty())
                {
                    if(!(nodeList = nodeList.at(0).toElement().elementsByTagName("Object")).isEmpty())
                    {
                        AttributeNodeMap = nodeList.at(0).attributes();
                        if(!AttributeNodeMap.namedItem("Type").isNull() && !AttributeNodeMap.namedItem("UID").isNull() &&
                                !(nodeList = nodeList.at(0).toElement().elementsByTagName("Properties")).isEmpty() &&
                                !(node = nodeList.at(0).attributes().namedItem("State")).isNull())
                        {
                            std::string sType = AttributeNodeMap.namedItem("Type").nodeValue().trimmed().toStdString();
                            std::string sUID = AttributeNodeMap.namedItem("UID").nodeValue().trimmed().toStdString();

                            if(node.nodeValue().trimmed() == "Tracked")
                            {
                                auto itTransponder = m_mTransponder.end();
                                if((itTransponder = std::find_if(m_mTransponder.begin(), m_mTransponder.end(), [sType, sUID](const std::map<int32_t, std::tuple<std::string, std::string, std::string, int32_t, int32_t, std::string>>::value_type &ItemData){return std::get<0>(ItemData.second) == sType && std::get<1>(ItemData.second) == sUID;})) != m_mTransponder.end())
                                {
                                    std::get<2>(itTransponder->second) = node.nodeValue().trimmed().toStdString();
                                }

                                bParseOK = true;
                            }
                        }
                    }
                    else
                    {
                       bParseOK = true;
                    }
                }
            }
        }
        SendUSBLDataToDisplay(doc);
    }

    return bParseOK;
}

【 在 pgw 的大作中提到: 】
: 你倒是贴几段赏析一下
--
FROM 221.219.211.*

这是重构后的代码
            QDomElement node = doc.documentElement()
                                   .firstChildElement("SynchStatus")
                                   .firstChildElement("Job")
                                   .firstChildElement("Objects");
            bParseOK = !node.isNull();

【 在 hgoldfish 的大作中提到: 】
: 我倒觉得这个代码还可以。非常清晰地说明这个代码里面是解析 xml 的代码，并且回复。
: 无论是 Qt 还是 JAVA，碰到解析 xml 都特别麻烦。除非使用 python 才简单一些，几个 query 就搞定了。业务代码就是烦。
--
FROM 111.199.185.*

我觉得会，甚至觉得应该禁止使用tuple

【 在 codeAnimal 的大作中提到: 】
: tuple会不会降低可读性？
--
FROM 111.199.188.*